-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(type-utils): isNullableType add Void logic #9937
feat(type-utils): isNullableType add Void logic #9937
Conversation
Thanks for the PR, @developer-bandi! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit af162fa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9937 +/- ##
==========================================
- Coverage 88.12% 86.01% -2.11%
==========================================
Files 406 425 +19
Lines 13951 14810 +859
Branches 4076 4308 +232
==========================================
+ Hits 12294 12739 +445
- Misses 1344 1722 +378
- Partials 313 349 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆒
Yeah, tests are a bit lacking in some of the ancillary packages.
3710c9c
into
typescript-eslint:main
PR Checklist
Overview
Since there are two rules using this utility function, I removed the same logic from the rule and added test code.
And I tried to add a unit test for isNullableType, but I couldn't find the original unit test file. Is it true that unit tests are not originally written for this utility file?