Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(type-utils): isNullableType add Void logic #9937

Merged

Conversation

developer-bandi
Copy link
Contributor

PR Checklist

Overview

Since there are two rules using this utility function, I removed the same logic from the rule and added test code.

And I tried to add a unit test for isNullableType, but I couldn't find the original unit test file. Is it true that unit tests are not originally written for this utility file?

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit af162fa
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66deec68fdf3780008b5f15a
😎 Deploy Preview https://deploy-preview-9937--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Sep 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit af162fa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.01%. Comparing base (6f24fe6) to head (af162fa).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9937      +/-   ##
==========================================
- Coverage   88.12%   86.01%   -2.11%     
==========================================
  Files         406      425      +19     
  Lines       13951    14810     +859     
  Branches     4076     4308     +232     
==========================================
+ Hits        12294    12739     +445     
- Misses       1344     1722     +378     
- Partials      313      349      +36     
Flag Coverage Δ
unittest 86.01% <ø> (-2.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 99.03% <ø> (+0.47%) ⬆️
...-plugin/src/rules/no-unnecessary-type-assertion.ts 97.95% <ø> (+0.02%) ⬆️
packages/type-utils/src/predicates.ts 21.21% <ø> (ø)

... and 28 files with indirect coverage changes

Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
void gif

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 12, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

Yeah, tests are a bit lacking in some of the ancillary packages.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3710c9c into typescript-eslint:main Sep 12, 2024
62 of 64 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Incorporate void check into isNullableType?
3 participants