Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unused-vars] incorporate upstream changes around caught errors report messages #9532

Merged
merged 9 commits into from
Jul 22, 2024

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Jul 9, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7bd3a69
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/669e4762392f140008b31fa5
😎 Deploy Preview https://deploy-preview-9532--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jul 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7bd3a69. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@abrahamguo abrahamguo changed the title feat(eslint-plugin): [no-unused-vars] Incorporate upstream changes around caught errors report messages feat(eslint-plugin): [no-unused-vars] incorporate upstream changes around caught errors report messages Jul 9, 2024
@abrahamguo abrahamguo marked this pull request as draft July 10, 2024 02:02
@abrahamguo abrahamguo changed the base branch from main to v8 July 10, 2024 02:15
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (ae980e3) to head (7bd3a69).

Additional details and impacted files
@@            Coverage Diff             @@
##               v8    #9532      +/-   ##
==========================================
+ Coverage   88.00%   88.01%   +0.01%     
==========================================
  Files         401      401              
  Lines       13647    13637      -10     
  Branches     3965     3960       -5     
==========================================
- Hits        12010    12003       -7     
  Misses       1325     1325              
+ Partials      312      309       -3     
Flag Coverage Δ
unittest 88.01% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/eslint-plugin/src/rules/no-unused-vars.ts 98.97% <100.00%> (+1.40%) ⬆️

@JoshuaKGoldberg
Copy link
Member

@abrahamguo did you mean to keep this as draft?

@abrahamguo
Copy link
Contributor Author

Yep! Still have to integrate the second PR. Working on that now, hoping to finish it today or tomorrow 👍

@abrahamguo abrahamguo marked this pull request as ready for review July 21, 2024 22:05
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - very clean and straightforward. Yay!

But given that @kirkwaiblinger authored >1 of the linked PRs, I'll defer to Kirk. 😄

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 22, 2024
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for doing this!

@kirkwaiblinger kirkwaiblinger changed the title feat(eslint-plugin): [no-unused-vars] incorporate upstream changes around caught errors report messages fix(eslint-plugin): [no-unused-vars] incorporate upstream changes around caught errors report messages Jul 22, 2024
@kirkwaiblinger kirkwaiblinger merged commit 87af726 into typescript-eslint:v8 Jul 22, 2024
68 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [no-unused-vars] Incorporate upstream changes around caught errors report messages
3 participants