fix(eslint-plugin): [no-require-imports] report only global require

[rafaelss95]

Fixes #3713.

[typescript-eslint]

Thanks for the PR, @rafaelss95!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit 954124c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx test @typescript-eslint/eslint-plugin-internal
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx run-many --target=typecheck --all --parallel
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/visitor-keys
	nx test @typescript-eslint/typescript-estree
	nx run-many --target=build --all --parallel
	nx run-many --target=build --all --parallel
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/visitor-keys
	nx test @typescript-eslint/typescript-estree

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #3871 (954124c) into master (4195919) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3871   +/-   ##
=======================================
  Coverage   93.50%   93.51%           
=======================================
  Files         151      151           
  Lines        8134     8137    +3     
  Branches     2580     2581    +1     
=======================================
+ Hits         7606     7609    +3     
  Misses        167      167           
  Partials      361      361           

Flag	Coverage Δ
unittest	93.51% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ages/eslint-plugin/src/rules/no-require-imports.ts	100.00% <100.00%> (ø)

[bradzacher]

thanks for doing this!
a few comments

[rafaelss95]

instead of copy-pasting it - let's move this to an internal util within the util folder and share the code.

https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin/src/util

@bradzacher, do you want me to do this in this PR (and also use it in no-shadow)?

Actually I just realized we can simply use ASTUtils.findVariable here and even in no-shadow (I can send another PR addressing this or maybe amend it to #3868). Let me know your thoughts.

[bradzacher]

(I can send another PR addressing this or maybe amend it to #3868). Let me know your thoughts.

Feel free to make another PR - keeps it clear and attributes each contribution to you :)