refactor(eslint-plugin): remove unnecessary if-statements in explicitReturnTypeUtils

[MichaelDeBoey]

No description provided.

[typescript-eslint]

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[codecov]

Codecov Report

Merging #3839 (3bd7a65) into master (dda9cee) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3839      +/-   ##
==========================================
- Coverage   93.51%   93.51%   -0.01%     
==========================================
  Files         151      151              
  Lines        8144     8143       -1     
  Branches     2584     2582       -2     
==========================================
- Hits         7616     7615       -1     
  Misses        167      167              
  Partials      361      361              

Flag	Coverage Δ
unittest	93.51% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ges/eslint-plugin/src/rules/no-inferrable-types.ts	93.33% <ø> (ø)
...nt-plugin/src/rules/no-unused-vars-experimental.ts	91.39% <ø> (ø)
...plugin/src/rules/explicit-module-boundary-types.ts	89.47% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts	77.34% <100.00%> (+0.17%)	⬆️
packages/eslint-plugin/src/rules/no-type-alias.ts	100.00% <100.00%> (ø)
...es/eslint-plugin/src/rules/no-use-before-define.ts	91.20% <100.00%> (+0.09%)	⬆️
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts	100.00% <100.00%> (ø)

[nx-cloud]

Nx Cloud Report

CI ran the following commands for commit 3bd7a65. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status	Command
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/eslint-plugin-internal
	nx test @typescript-eslint/eslint-plugin-tslint
	nx test @typescript-eslint/eslint-plugin
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/visitor-keys
	nx test @typescript-eslint/typescript-estree
	nx run-many --target=build --all --parallel
	nx run-many --target=typecheck --all --parallel
	nx test @typescript-eslint/parser
	nx test @typescript-eslint/experimental-utils
	nx test @typescript-eslint/scope-manager
	nx test @typescript-eslint/visitor-keys
	nx test @typescript-eslint/typescript-estree
	nx run-many --target=build --all --parallel
	nx prebuild @typescript-eslint/types
	nx prebuild @typescript-eslint/types

---

Sent with 💌 from NxCloud.

[bradzacher]

instead of an implicit boolean coercion via the Boolean constructor - prefer an explicit logical check as it's clearer

[bradzacher]

I think i got the logic conversion wrong because I'm an idiot? Cos all the tests started failing.

[bradzacher]

thanks!