Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add currencies ZAR and NAD. Add MoneyContext.withAdditionalCurrencies #294

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Add currencies ZAR and NAD. Add MoneyContext.withAdditionalCurrencies #294

merged 1 commit into from
Jan 23, 2018

Conversation

garyKeorkunian
Copy link
Contributor

Fixes #291

@derekmorr
Copy link
Collaborator

I'd love to find a good way to solve this in a general way, since we have the same problem with every other Dimension. For now, withAdditionalCurrencies is workable.

cquiroz
cquiroz approved these changes Jan 23, 2018
View reviewed changes
Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garyKeorkunian
Copy link
Contributor Author

Yes, it would be nice to get that into the dimensions. Of course, MarketContext is a class so it's a bit easier here.

@garyKeorkunian garyKeorkunian merged commit c76920e into master Jan 23, 2018
@larsrh larsrh deleted the wip-new-currencies branch July 29, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekmorr derekmorr derekmorr approved these changes

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garyKeorkunian @derekmorr @cquiroz