Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ElectricFieldStrength, implement ElectricPotential unimplemented method #272

Merged
merged 5 commits into from
Jun 25, 2017

Conversation

nvinuesa
Copy link
Contributor

This is the 4th PR concerning #252

object ElectricFieldStrength extends Dimension[ElectricFieldStrength] {
private[electro] def apply[A](n: A, unit: ElectricFieldStrengthUnit)(implicit num: Numeric[A]) = new ElectricFieldStrength(num.toDouble(n), unit)
def apply = parse _
def name = "ElectricFieldStrength"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of these could be val as we've discussed in other PRs

Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me. I'll leave it open for others to comment

@derekmorr derekmorr modified the milestone: 1.4 Jun 25, 2017
@derekmorr derekmorr merged commit 258d2b7 into typelevel:master Jun 25, 2017
@nvinuesa nvinuesa deleted the issue-252-4 branch July 25, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants