Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: replace connection pool #559

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

WIP: replace connection pool #559

wants to merge 4 commits into from

Conversation

tpolecat
Copy link
Member

@tpolecat tpolecat commented Oct 5, 2021

This replaces the built-in pool with pool-party, which is a lot simpler and has much better diagnostics. We need to hook in a default event listener that at least reports errors.

This also drops support for 2.12 because of annoying issues getting pool-party to compile, but I guess I should look into it a little bit more because it's going to annoy people.

After merging we need to tag an RC to let people test the new pool before a full upgrade, since it's a potentially big problem if it's buggier than the existing pool (I don't think it is but concurrency is hard).

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2021

Codecov Report

Merging #559 (1734184) into main (ae26b0b) will decrease coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   85.27%   84.95%   -0.33%     
==========================================
  Files         124      123       -1     
  Lines        1596     1575      -21     
  Branches       34       35       +1     
==========================================
- Hits         1361     1338      -23     
- Misses        235      237       +2     
Impacted Files Coverage Δ
modules/core/shared/src/main/scala/Session.scala 54.54% <100.00%> (+0.69%) ⬆️
...les/core/shared/src/main/scala/util/Recycler.scala 42.85% <0.00%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae26b0b...1734184. Read the comment docs.

@mpilquist mpilquist mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants