Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-build for Scala.js #515
Cross-build for Scala.js #515
Changes from 1 commit
ea80181
d614a86
b69fc2f
dc7dc14
de451e2
f80fde7
e6f2ef6
12f37ac
e40f79b
b3def34
07d9060
8a9ce4a
0d6a531
82da921
6a30a4b
b99cf2a
39641e0
1c765af
23196a1
baaff4e
fab9edf
a45e7fa
44c3685
d496282
ee6a718
92962b9
5eb60ce
c2e9d41
0eb4153
3bbb286
f7029e2
333c343
6091dd0
92024dc
272e121
23ec9f1
ee6dae2
291841f
f42b0c9
bb8a60c
0882e77
7f3c2c1
14b21f5
89535fd
9bc52c9
68a4bf0
1983d99
694f0d5
ddb57ba
cdc08ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate? PBKDF-2 should be completely CPU bound
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Node.js offers an async version of this method with a callback. I assume they have a good reason for doing so.
My best guess would be that you are indeed right that it is CPU-bound, but it's CPU intensive enough that it would detrimentally block a single-threaded Node.js app.