[Commands] Fix MatchError when using multiple workers #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`for (Some(v) <- Map(...).values) yield v` would throw MatchError as
soon as it tries to process a value that doesn't conform to Some(v).
The tests didn't detect this because `property("...") = rhs` was
re-evaluating `rhs` each time the property is evaluated, which means
that Commands.property() only ran one evaluation at a time
(so suts would always be empty when we run those for comprehensions)
rossabaker
approved these changes
Jun 4, 2022
|
Ready to merge whenever, though it looks like you might need to manually trigger the tests for this PR. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #893
for (Some(v) <- Map(...).values) yield vwould throw MatchError as soon as it tries to process a value that doesn't conform to Some(v).The tests didn't detect this because
property("...") = rhswas re-evaluatingrhseach time the property is evaluated, which means that Commands.property() only ran one evaluation at a time (sosutswould always be empty when we run those for comprehensions).