-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support scala-native Scala 3 build #868
Conversation
3e2ac00
to
b4cd826
Compare
@@ -32,7 +32,7 @@ ThisBuild / githubWorkflowBuildMatrixInclusions ++= | |||
} | |||
|
|||
ThisBuild / githubWorkflowBuildMatrixInclusions ++= | |||
crossScalaVersions.value.filter(_.startsWith("2.")) map { scala => | |||
crossScalaVersions.value.filterNot(_ == Scala30) map { scala => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- https://repo1.maven.org/maven2/org/scala-native/nscplugin_3.1.0/
- https://scala-native.readthedocs.io/en/latest/changelog/0.4.3-RC1.html
The minimal version of Scala 3 supported by Scala Native is 3.1.0, due to fatal blockers in Scala 3.0.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it were up to me, I would release Scala 3 native with a minor version increase (1.16.0), which would only be published for Scala 3.1.
b4cd826
to
676705c
Compare
676705c
to
8fe8e36
Compare
8fe8e36
to
b69352c
Compare
What is the current status of this PR? Having scala-native support will be awesome. |
Is this PR still necessary if we merge #875? |
This PR requires Scala 3.1. |
Can we use Scala 3.0.x for all of the CI matrix entries except for the Scala 3 + Scala Native combination, which would use 3.1.x? |
Needs rebase. |
Maybe, these sorts of hacks seem to cause problems see e.g. portable-scala/sbt-crossproject#130. After all this build engineering I'm not really into build hacks ... if people really want this now, I think we should all bump to Scala 3.1. It's the first Scala 3 supported on all platforms anyway |
I personally am a proponent for moving to 3.1 ecosystem-wide and just pretending 3.0 never existed. I highly doubt there are any 3.0 users out there who can't simply upgrade to 3.1. But I admit to feeling trepidation and indecision on that point in this repo in particular, since it's upstream of so vastly much of the ecosystem. |
@vasilmkd had an idea that we bump the minor version and go to Scala 3.1. If it becomes a problem, we can continue "maintaining" the current minor series as another branch ... but things have been moving slow here anyway, not sure what critical maintenance would show up on that branch. |
I would still advise on bumping the minor version in the release that ships on 3.1, because it signals a forward incompatible change. |
Even if we invoke the |
I don't trust it without an experiment. |
#879 is merged (moving us to 3.1), so I guess this should be rebased now? |
#879 actually supersedes this one, so we can close. |
No description provided.