Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support scala-native Scala 3 build #868

Closed
wants to merge 1 commit into from

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Jan 5, 2022

No description provided.

@xuwei-k xuwei-k force-pushed the native-scala-3 branch 2 times, most recently from 3e2ac00 to b4cd826 Compare January 5, 2022 00:32
build.sbt Outdated Show resolved Hide resolved
@@ -32,7 +32,7 @@ ThisBuild / githubWorkflowBuildMatrixInclusions ++=
}

ThisBuild / githubWorkflowBuildMatrixInclusions ++=
crossScalaVersions.value.filter(_.startsWith("2.")) map { scala =>
crossScalaVersions.value.filterNot(_ == Scala30) map { scala =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimal version of Scala 3 supported by Scala Native is 3.1.0, due to fatal blockers in Scala 3.0.x.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it were up to me, I would release Scala 3 native with a minor version increase (1.16.0), which would only be published for Scala 3.1.

@vasilmkd
Copy link
Member

vasilmkd commented Jan 5, 2022

@xuwei-k Is it maybe easier to base this PR on top of #860, which unfortunately wasn't looked at by any other maintainer.

@kpodsiad
Copy link

What is the current status of this PR? Having scala-native support will be awesome.

@rossabaker
Copy link
Member

Is this PR still necessary if we merge #875?

@armanbilge
Copy link
Member

This PR requires Scala 3.1.

@SethTisue
Copy link
Member

Can we use Scala 3.0.x for all of the CI matrix entries except for the Scala 3 + Scala Native combination, which would use 3.1.x?

@SethTisue
Copy link
Member

Needs rebase.

@SethTisue SethTisue marked this pull request as draft March 15, 2022 13:27
@armanbilge
Copy link
Member

Maybe, these sorts of hacks seem to cause problems see e.g. portable-scala/sbt-crossproject#130.

After all this build engineering I'm not really into build hacks ... if people really want this now, I think we should all bump to Scala 3.1. It's the first Scala 3 supported on all platforms anyway

@SethTisue
Copy link
Member

SethTisue commented Mar 15, 2022

I personally am a proponent for moving to 3.1 ecosystem-wide and just pretending 3.0 never existed. I highly doubt there are any 3.0 users out there who can't simply upgrade to 3.1.

But I admit to feeling trepidation and indecision on that point in this repo in particular, since it's upstream of so vastly much of the ecosystem.

@armanbilge
Copy link
Member

armanbilge commented Mar 15, 2022

@vasilmkd had an idea that we bump the minor version and go to Scala 3.1. If it becomes a problem, we can continue "maintaining" the current minor series as another branch ... but things have been moving slow here anyway, not sure what critical maintenance would show up on that branch.

@vasilmkd
Copy link
Member

I would still advise on bumping the minor version in the release that ships on 3.1, because it signals a forward incompatible change.

@armanbilge
Copy link
Member

armanbilge commented Mar 15, 2022

Even if we invoke the -Yscala-release flag? (edit: or whatever its called now)

@vasilmkd
Copy link
Member

I don't trust it without an experiment.

This was referenced Mar 15, 2022
@SethTisue
Copy link
Member

#879 is merged (moving us to 3.1), so I guess this should be rebased now?

@armanbilge
Copy link
Member

#879 actually supersedes this one, so we can close.

@SethTisue SethTisue closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants