Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix CI build script #792

Merged
merged 1 commit into from
Apr 10, 2021
Merged

fix CI build script #792

merged 1 commit into from
Apr 10, 2021

Conversation

larsrh
Copy link
Contributor

@larsrh larsrh commented Apr 10, 2021

Turns out those extra quotes didn't do what we thought they would.

@larsrh larsrh added this to the 1.15.4 milestone Apr 10, 2021
@larsrh larsrh mentioned this pull request Apr 10, 2021
Merged
@ashawley
Copy link
Contributor

Good catch, Lars!!!

@larsrh
Copy link
Contributor Author

larsrh commented Apr 10, 2021

Random catch, I was looking through some CI log and it complained about invalid arguments 😅

@larsrh larsrh merged commit 98e740e into main Apr 10, 2021
@larsrh larsrh deleted the topic/fix-script branch April 10, 2021 17:07
@ashawley
Copy link
Contributor

That explains what I saw in #783, then?

@larsrh
Copy link
Contributor Author

larsrh commented Apr 10, 2021

Possibly. If you rebase that one you should also see the Scaladoc error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashawley ashawley ashawley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.4
Development

Successfully merging this pull request may close these issues.
2 participants
@larsrh @ashawley