Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arbitrary[Symbol] #785

Merged
merged 1 commit into from
Apr 9, 2021
Merged

Add Arbitrary[Symbol] #785

merged 1 commit into from
Apr 9, 2021

Conversation

ashawley
Copy link
Contributor

@ashawley ashawley commented Apr 8, 2021

Fixes #243.

Quoted symbol is deprecated in Scala 2.13, but the Symbol class is still available.

@ashawley
Copy link
Contributor Author

ashawley commented Apr 8, 2021

There was a reference to a binary compatibility issue, but I'm not sure why MiMa would report that as being the case.

@ashawley
Copy link
Contributor Author

ashawley commented Apr 8, 2021

Build passes with the latest MiMa 0.8.1. When Erik tried this 5 years ago it was MiMa 0.1.9, fwiw.

@larsrh larsrh merged commit 74e0db2 into typelevel:main Apr 9, 2021
@larsrh
Copy link
Contributor

larsrh commented Apr 9, 2021

I think the issue 5 years ago was the trait encoding of Scala pre-2.12 😉

@ashawley ashawley deleted the arbitrary-symbol branch April 10, 2021 14:47
@ashawley ashawley added this to the 1.15.4 milestone Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arbitrary instance for Symbol
2 participants