Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add choose methods for both Java and Scala BigDecimal. #670

Merged
merged 4 commits into from
Oct 24, 2020
Merged

Add choose methods for both Java and Scala BigDecimal. #670

merged 4 commits into from
Oct 24, 2020

Commits on Jul 1, 2020

  1. Add choose methods for both Java and Scala BigDecimal. 

    In addition to implicit Choose instances for scala.math.BigDecimal and
java.math.BigDecimal we also include explicit constructor methods, since users
may wish to be explicit about the scale they want. We may want to put those
methods directly on Gen, currently the ergonomics of using this are a bit bad:

    Gen.Choose.chooseBigDecimalScale(100).choose(0, 1)

The BigDecimal generation is not yet tested. That will also be added in a
follow up. This also optimizes the BigInt generator a bit and generalizes it to
java.math.BigInteger to support that as well.

Addresses typelevel#631, typelevel#637, and typelevel#664
    @non
    non committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    4d15dae View commit details
    Browse the repository at this point in the history

  2. remove unused import

    @non
    non committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    73358af View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. Additional testing for Choose[BigDecimal].

    @non
    non committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    c0cd397 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2020

  1. Make scale-based methods private.

    @non
    non committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    5738d0c View commit details
    Browse the repository at this point in the history