Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to self instead of Gen.this #605

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Conversation

ashawley
Copy link
Contributor

@ashawley ashawley commented Jan 8, 2020

Code cherry-picked from #575

This is part of work on Gen performance improvements.
@ashawley
Copy link
Contributor Author

ashawley commented Jan 8, 2020

This shouldn't change performance either, but just to be sure:

> bench/jmh:run -wi 3 -i 3 -f1 -t1 org.scalacheck.bench.GenBench
Benchmark                   (genSize)  (seedCount)  Mode  Cnt      Score       Error  Units
GenBench.arbitraryString          100          100  avgt    3   3509.829 ±  4449.755  us/op
GenBench.asciiPrintableStr        100          100  avgt    3   2075.803 ±   648.052  us/op
GenBench.const_                   100          100  avgt    3      4.289 ±     1.790  us/op
GenBench.double_                  100          100  avgt    3     12.758 ±     2.255  us/op
GenBench.dynamicFrequency         100          100  avgt    3   2054.676 ±   910.133  us/op
GenBench.eitherIntInt             100          100  avgt    3     59.577 ±   121.032  us/op
GenBench.identifier               100          100  avgt    3   4598.152 ±  1794.132  us/op
GenBench.int_                     100          100  avgt    3     16.283 ±     0.308  us/op
GenBench.listOfInt                100          100  avgt    3   1943.837 ±   604.833  us/op
GenBench.mapOfIntInt              100          100  avgt    3   4507.883 ±  6738.781  us/op
GenBench.oneOf                    100          100  avgt    3     25.058 ±    11.399  us/op
GenBench.optionInt                100          100  avgt    3     68.185 ±    17.478  us/op
GenBench.sequence                 100          100  avgt    3    304.392 ±   297.912  us/op
GenBench.staticFrequency          100          100  avgt    3   2395.711 ±  1302.816  us/op
GenBench.testFilter               100          100  avgt    3  25521.167 ± 32727.678  us/op
GenBench.zipIntInt                100          100  avgt    3     36.341 ±     6.253  us/op

@ashawley ashawley merged commit 9847100 into typelevel:master Jan 9, 2020
@ashawley ashawley deleted the use-self branch January 10, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants