Fix shrinking of failed test cases in Commands

[nrinaudo]

This should fix #447.

Remaining questions:

• why does this fix the issue?!
• if I wanted to write a test for this, how would I go about it?

[joroKr21]

Did you try adding a type annotation to the value? Implicits should always have it because otherwise weird things like this could happen.

[nrinaudo]

Oh wow I did not even realize it didn’t have one- my projects are set up to not compile when that happens, it’s kind of a blind spot for me now. I’ll fix that, thanks!

[nrinaudo]

@joroKr21 well spotted, that's a much more satisfying fix.

Might I suggest adding wartremover, or any other linting tool that fails builds when implicits are not type annotated?

[ashawley]

I tried it locally and the failure shrinks now on 2.12. Thanks for tracking this down!

The ability to test shrinking failures is a missing feature. This looks good to merge to me.

[nrinaudo]

Apologies - my default email is the work one and I tend to forget to change it. This should be ok now.

[JD557]

Any updates on this? Is anything blocking this PR?

It would be really helpful to make sure that this makes it into 1.14.1, since otherwise using Commands in scala 2.12 is a real pain, since (AFAIK) there's no easy way to find out what command failed the post condition.

[ashawley]

An issue about releasing 1.14.1 was opened as #453.

Please add your questions, comments and thumbs up about the release there.