Fix Mima settings #402
Closed
Fix Mima settings #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves typelevel#397 I'm not sure whether or not we theoretically lose any compatibility checks by using `%%` instead of `%%%`. Hopefully someone with more Scala.js and/or Scala Native experience can weigh in on that.
|
#399 also tried to fix mima |
|
Oh sorry about that @ashawley I missed that one. I'll close this out in favor of that one. |
|
No worries. Sorry that I didn't link through the issues. Bad etiquette on my part. Yeah, hopefully someone with Scalajs and Native experience turns up and weighs in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #397
I'm not sure whether or not we theoretically lose any compatibility
checks by using
%%instead of%%%. Hopefully someone with moreScala.js and/or Scala Native experience can weigh in on that.