Revert 2.12.0-M4 changes #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were changes that were made for fixing errors in a 2.12 milestone and also a fix that avoided breaking binary compatability in 1.13.0 for the bootstrap process.
|
This change cause ambiguous error with Scala 2.11.12 and |
xuwei-k
added a commit
to xuwei-k/scalacheck
that referenced
this pull request
Apr 27, 2018
xuwei-k
added a commit
to xuwei-k/scalacheck
that referenced
this pull request
Apr 27, 2018
Merged
fommil
reviewed
Jun 21, 2018
| @@ -30,8 +30,7 @@ sealed trait Cogen[T] extends Serializable { | |||
|
|
|||
| object Cogen extends CogenArities with CogenLowPriority { | |||
|
|
|||
| // See https://github.com/rickynils/scalacheck/issues/230 for dummy expl. | |||
| def apply[T](implicit ev: Cogen[T], dummy: Cogen[T]): Cogen[T] = ev | |||
There was a problem hiding this comment.
Yes it did break bincompat. I believe it should have only been released in 1.14.0, and not in 1.13.x.
There was a problem hiding this comment.
hmm. Interesting. I am seeing the breakage in 1.13.x.
There was a problem hiding this comment.
it is possible something is transitively pulling in 1.14.x in my project. I'll check that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were changes that were made for fixing errors in a 2.12 milestone and also a fix that avoided breaking binary compatability in 1.13.0 for the bootstrap process.
This reverts #230 it was already partially reverted in 8abd189