Fix Gen.choose for Double infinity #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to verify #379 with the following test that checks that there is at least one non-zero value in a sample of three:
Here it is failing currently:
The test assumes that flipping a
Double.MaxValue
-sided coin and getting a zero three times in a row is impossible. Someone may need to check my math on that.The fix here just substitutes
Double.MinValue
forDouble.NegativeInfinity
andDouble.MaxValue
forDouble.PositiveInfinity
in the internal functionGen.Choose.chDbl
, and also adds the special constantsDouble.NegativeInfinity
andDouble.PositiveInfinity
at a frequency of 10% (for both respectively).