Merge pull request #497 from ashawley/improve-param-errors

Improve errors for test parameters
typelevel · Aug 7, 2019 · ce0e23e · ce0e23e
2 parents aaffe1e + 0315fec
commit ce0e23e
Showing 1 changed file with 15 additions and 8 deletions.
diff --git a/src/main/scala/org/scalacheck/Test.scala b/src/main/scala/org/scalacheck/Test.scala
@@ -215,14 +215,21 @@ object Test {
   }
 
   private def assertParams(prms: Parameters) = {
-    import prms._
-    if(
-      minSuccessfulTests <= 0 ||
-      maxDiscardRatio <= 0 ||
-      minSize < 0 ||
-      maxSize < minSize ||
-      workers <= 0
-    ) throw new IllegalArgumentException("Invalid test parameters")
+    if (prms.minSuccessfulTests <= 0)
+      throw new IllegalArgumentException(
+        s"Invalid test parameter: minSuccessfulTests (${prms.minSuccessfulTests}) <= 0")
+    else if (prms.maxDiscardRatio <= 0)
+      throw new IllegalArgumentException(
+        s"Invalid test parameter: maxDiscardRatio (${prms.maxDiscardRatio}) <= 0")
+    else if (prms.minSize < 0)
+      throw new IllegalArgumentException(
+        s"Invalid test parameter: minSize (${prms.minSize}) < 0")
+    else if (prms.maxSize < prms.minSize)
+      throw new IllegalArgumentException(
+        s"Invalid test parameter: maxSize (${prms.maxSize}) < minSize (${prms.minSize})")
+    else if (prms.workers <= 0)
+      throw new IllegalArgumentException(
+        s"Invalid test parameter: workers (${prms.workers}) <= 0")
   }
 
   private[scalacheck] lazy val cmdLineParser = new CmdLineParser {