Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Boolean test transformer #354

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Conversation

TonioGela
Copy link
Member

Solves #25. Thanks to @adrian-salajan for the implementation.

P.S. The implementation could have been more barebone, like

  implicit def effectOfBooleanToPropF[F[_]](
      fu: F[Unit]
  )(implicit F: MonadError[F, Throwable]): PropF[F] =
    Suspend[F, Result[F]](
      fu.map(boolean(_))
        .handleError(t => Result[F](Prop.Exception(t), Nil, Set.empty, Set.empty))
    )

or similar, is this preferrable?

Copy link
Contributor

@satorg satorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@TonioGela
Copy link
Member Author

@satorg I swear I'll do my best to keep track of this PR, but if we don't merge it I fear I'll forget about it soon :D

@satorg satorg merged commit aabddc7 into typelevel:main Jun 9, 2024
11 checks passed
@satorg
Copy link
Contributor

satorg commented Jun 9, 2024

@TonioGela , thank you for the ping.
Usually I don't merge if I'm the only reviewer – just to let someone else review it. But looks like this repository doesn't have that many active maintainers now to make it working.

Thank you for the contribution again – it can come handy in some cases indeed!

@TonioGela TonioGela deleted the BooleanTests branch June 9, 2024 19:17
@TonioGela
Copy link
Member Author

Thanks for merging it @satorg

But looks like this repository doesn't have that many active maintainers now to make it working.

That's precisely the reason I nudged this a bit. To avoid forgetting about it, not to be rude or hijack other maintainers' will. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants