Look for X-Ray headers in system property #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpholt
commented
Dec 8, 2023
armanbilge
reviewed
Dec 8, 2023
Per the OTel semantic conventions for instrumenting AWS Lambda[1], and the documentation of AWS Lambda environment variables[2], instrumentation should first attempt to retrieve the trace context from the system property before falling back to the environment variable as a legacy behavior. [1] https://opentelemetry.io/docs/specs/semconv/faas/aws-lambda/#aws-x-ray-environment-span-link [2] https://docs.aws.amazon.com/lambda/latest/dg/configuration-envvars.html#configuration-envvars-runtime
|
@armanbilge I updated with your suggestions, thank you! |
armanbilge
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the OTel semantic conventions for instrumenting AWS Lambda, and the documentation of AWS Lambda environment variables, instrumentation should first attempt to retrieve the trace context from the system property before falling back to the environment variable as a legacy behavior.
Fixes #927.