Add mock to root aggregate
#707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did the bare minimum to fix compile, but still need to actually integrate the new APIs. |
|
Ahh my open source creds! Im happy to look into it. It will help me wrap my head around natchez |
daddykotex
approved these changes
Jan 24, 2023
|
Can we get that merged and released or do you prefer to have: |
|
Oh maybe I misunderstood, I thought you had volunteered to look into that? 😅 |
Yeah, I will. I was just thinking you'd cut a release just to have all artifacts at 3+, then I could come around with proper usage of the new apis. But it's fine, I will come up with a PR as fast as I can |
|
Opened armanbilge#1 on your branch |
|
superseeded by #712 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.