Merge pull request #806 from cb372/datadog-remove-error-propagation

Datadog: do not propagate error to root span
typelevel · May 23, 2023 · 7da9611 · 7da9611
2 parents 1749110 + ec4c927
commit 7da9611
Showing 1 changed file with 1 addition and 12 deletions.
diff --git a/modules/datadog/src/main/scala/DDSpan.scala b/modules/datadog/src/main/scala/DDSpan.scala
@@ -15,7 +15,6 @@ import io.opentracing.propagation.{Format, TextMapAdapter}
 import io.opentracing.tag.Tags
 import natchez.TraceValue.{BooleanValue, NumberValue, StringValue}
 import _root_.datadog.trace.api.DDTags
-import _root_.datadog.trace.api.interceptor.MutableSpan
 import natchez.Span.Options
 import natchez.datadog.DDTracer.{addLink, addSpanKind}
 
@@ -101,17 +100,7 @@ final case class DDSpan[F[_]: Sync](
       DDTags.ERROR_MSG -> err.getMessage,
       DDTags.ERROR_TYPE -> err.getClass.getSimpleName,
       DDTags.ERROR_STACK -> err.getStackTrace.mkString
-    ) >> {
-      // Set error on root span
-      span match {
-        case ms: MutableSpan =>
-          Sync[F].delay {
-            val localRootSpan = ms.getLocalRootSpan
-            localRootSpan.setError(true)
-          }.void
-        case _ => Sync[F].unit
-      }
-    } >>
+    ) >>
       Sync[F].delay {
         span.log(
           (Map(