-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding effect's contextual environment to the log context #800
base: main
Are you sure you want to change the base?
Conversation
build.sbt
Outdated
@@ -47,7 +48,8 @@ lazy val core = crossProject(JSPlatform, JVMPlatform, NativePlatform) | |||
name := "log4cats-core", | |||
libraryDependencies ++= Seq( | |||
"org.typelevel" %%% "cats-core" % catsV, | |||
"org.typelevel" %%% "cats-effect-std" % catsEffectV | |||
"org.typelevel" %%% "cats-effect-std" % catsEffectV, | |||
"org.typelevel" %%% "cats-mtl" % catsMtlV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The drawback of having this functionality in the core
module.
I can move this code into log4cats-extras
module. It could be handy if we want to provide some 'non-trivial' functionality: invocation positions (#525), etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an idea, maybe it's worth creating a log4cats-mtl
module then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid point
d0bf3e7
to
8f5d723
Compare
8f5d723
to
82dea75
Compare
I made Should I set an upcoming release via |
If we are making a Just want to make sure that we think about the migration path in the case MTL ends up on the |
Is there any ETA? It would be nice to have Local as a part of cats-effect. |
It could be as early as Cats Effect 3.6. I think last time that we discussed it Daniel was pretty convinced. |
Closes #461. Some ideas are based on #676.