Migrate to sbt-typelevel in series/1.x
#603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicheg
force-pushed
the
series/1.x-sbt-typelevel
branch
from
13040ef
to
7d58e9c
Compare
armanbilge
reviewed
Feb 2, 2022
| @@ -6,6 +6,8 @@ ThisBuild / tlBaseVersion := "1.5" | |||
| ThisBuild / crossScalaVersions := Seq(Scala213, Scala212, Scala3) | |||
| ThisBuild / scalaVersion := Scala213 | |||
| ThisBuild / startYear := Some(2018) | |||
| ThisBuild / tlSitePublishBranch := None | |||
There was a problem hiding this comment.
Suggested change
| ThisBuild / tlSitePublishBranch := None |
If you publish the site for 1.x tags, then it will override the 2.x site. Either we should set up versioned documentation, or you should never publish the site from the 1.x branch/tags ever. WDYT?
There was a problem hiding this comment.
Eh, you're probably right. I think sbt-typelevel should have some explicit settings to disable publishing site. It could be odd from some angle but it makes sense in the case of the multibranch project without a versioned site. I think it's worth discussing it in the sbt-typelevel space.
There was a problem hiding this comment.
@armanbilge I've started typelevel/sbt-typelevel#137, so would be lovely to get your thoughts on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #592.