-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative : Alternative io log4s proposal #33
Merged
Merged
Commits on May 27, 2018
-
Integrate iolog4s macro implementation in slf4j module
The log4cats-slf4j module now uses the macro based implementation from iolog4s: https://iolog4s.github.io/iolog4s/ This one is essentially identical to the log4s approach, but macros generate code that wrap statements in F.delay when appropriate.
Configuration menu - View commit details
-
Copy full SHA for 1fef04e - Browse repository at this point
Copy the full SHA 1fef04eView commit details -
Make Slf4jLogger no longer crash when its used with the Logger[F] type
This solution fixes a problem in the previous commit where the program would crash with ??? when the logger was being referenced from the `Logger[F]` interface. What this implementation effectively achives is that when the user uses the the the slf4j backend wrapper via the subtype io.chrisdavenport.log4cats.slf4j.Slf4jLogger then they get macro-based optimizations like you see in iolog4s. But when they switch to the abstract algebra of `Logger[F]` then they lose this macro-based optimization and they get something that is equivalent to the old log4cats wrapper.
Configuration menu - View commit details
-
Copy full SHA for 3dae97b - Browse repository at this point
Copy the full SHA 3dae97bView commit details
Commits on May 29, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b34dfa0 - Browse repository at this point
Copy the full SHA b34dfa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 287a687 - Browse repository at this point
Copy the full SHA 287a687View commit details -
Configuration menu - View commit details
-
Copy full SHA for 955d1de - Browse repository at this point
Copy the full SHA 955d1deView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8367a3 - Browse repository at this point
Copy the full SHA b8367a3View commit details
Commits on May 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c50d146 - Browse repository at this point
Copy the full SHA c50d146View commit details -
Configuration menu - View commit details
-
Copy full SHA for 586c37b - Browse repository at this point
Copy the full SHA 586c37bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.