Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add durationBetweenEvictionRuns configuration #561

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Add durationBetweenEvictionRuns configuration #561

merged 5 commits into from
Jul 29, 2024

Conversation

samspills
Copy link
Contributor

This adds a configuration for durationBetweenEvictionRuns a la commons-pool2.

  • following the documentation in commons-pool2, I have implemented it so that a negative duration or an infinite duration will disable the reaper thread entirely
  • I have maintained the previous 5.seconds constant in the deprecated KeyPoolBuilder

closes #556

@samspills samspills self-assigned this Jul 10, 2024
@rossabaker rossabaker merged commit 10d86a6 into typelevel:main Jul 29, 2024
12 checks passed
@samspills samspills deleted the sam/556/duration-between-eviction-runs branch July 29, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker rossabaker approved these changes

@zarthross zarthross zarthross approved these changes

@EstebanMarin EstebanMarin EstebanMarin approved these changes

Assignees

@samspills samspills

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement durationBetweenEvictionRuns
4 participants
@samspills @rossabaker @zarthross @EstebanMarin