-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Establish Spark 3.x & Scala 2.13 cross publish #573
Conversation
2698a96
to
8530cf2
Compare
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
==========================================
+ Coverage 95.13% 95.14% +0.01%
==========================================
Files 65 65
Lines 1131 1134 +3
Branches 11 5 -6
==========================================
+ Hits 1076 1079 +3
Misses 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
6a248b4
to
de2d72a
Compare
dataset/src/main/scala/frameless/functions/NonAggregateFunctions.scala
Outdated
Show resolved
Hide resolved
@cchantep what are your thoughts about merging this one? I would like to suggest to cut a release with 3.1.x in deps before merging this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As-is it would break compatibility (e.g. functions.{shiftrightunsigned,bitwise_not}
), so unless a cross-version build is set up, I won't merge that.
56c3fc8
to
bf27a12
Compare
dataset/src/main/scala/frameless/functions/NonAggregateFunctions.scala
Outdated
Show resolved
Hide resolved
dataset/src/main/scala/frameless/functions/NonAggregateFunctions.scala
Outdated
Show resolved
Hide resolved
f51ebf5
to
b62ecf6
Compare
1911a94
to
844fe3e
Compare
6faff65
to
cafd1e3
Compare
1190634
to
9ed1527
Compare
9ed1527
to
d716519
Compare
e288560
to
815a004
Compare
815a004
to
c9e8f72
Compare
Co-authored-by: Cédric Chantepie <[email protected]>
Merging! Let's see how the snapshot deployment goes (hopefully well!) |
TODO:
check that 3.2.0 version would still properly work with Spark 3.1.x, is it even possible or we would delay this PR merge due to compatability reasons.incompatible , see Establish Spark 3.x & Scala 2.13 cross publish #573 (comment) (it was expected but still worth checking)irrec-regex-gen
test dependencysbt-github-actions
(we have a bit more complicated release process now)This PR slightly changes the release process:
-spark-{major}{minor}
is added to artifacts that are released for the previous Spark version(s).Artifact names examples:
frameless-dataset
(the latest Spark dependency)frameless-dataset-spark31
(Spark 3.1.x dependency)frameless-dataset-spark30
(Spark 3.0.x dependency)Closes #554
Closes #570
Closes #553