Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt-typelevel-ci-release #1631

Merged
merged 11 commits into from
Jan 11, 2022
Merged

sbt-typelevel-ci-release #1631

merged 11 commits into from
Jan 11, 2022

Conversation

tpolecat
Copy link
Member

No description provided.

@armanbilge
Copy link
Member

You should remove the scalaVersion setting, and set ThisBuild / crossScalaVersions. If scala213 is last in the list, it will be your default scalaVersion when you start sbt. (This is all inherited from sbt-gh-actions btw.)

    scalaVersion := scala213Version,
    crossScalaVersions := Seq(scala212Version, scala213Version, scala30Version),

build.sbt Outdated
Comment on lines 42 to 45
WorkflowStep.Run(
commands = List("sbt docs/makeSite"), // don't run the matrix build, it only works for `scalaVersion`
name = Some("Check Headers"),
)
Copy link
Member

@armanbilge armanbilge Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another trick you can do is

Suggested change
WorkflowStep.Run(
commands = List("sbt docs/makeSite"), // don't run the matrix build, it only works for `scalaVersion`
name = Some("Check Headers"),
)
WorkflowStep.Sbt(
commands = List("docs/makeSite")
name = Some("Check Headers"),
cond = Some(s"matrix.scala == '$scala213Version'"),
)

ThisBuild / developers += tlGitHubDev("tpolecat", "Rob Norris")
ThisBuild / tlSonatypeUseLegacyHost := false
ThisBuild / githubWorkflowJavaVersions := Seq(JavaSpec.temurin("11"))
ThisBuild / githubWorkflowBuildPreamble ++= Seq(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI there's also githubWorkflowBuild (the default ci step resides in here) and githubWorkflowBuildPostamble.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm yeah maybe I should do docs last.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw we're going to bake in the docs step, I forgot its essential to publishing.

@tpolecat
Copy link
Member Author

Alright let's see how it does.

@tpolecat tpolecat merged commit 8297aa8 into main Jan 11, 2022
@tpolecat tpolecat deleted the sbt-typelevel branch January 11, 2022 19:03
@armanbilge armanbilge mentioned this pull request Jan 13, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants