updated to 2.13-M5 #2589

kailuowang · 2018-10-31T15:46:41Z

Hopefully we can merge this one quickly and publish 1.5

codecov-io · 2018-10-31T17:01:15Z

Codecov Report

Merging #2589 into master will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2589      +/-   ##
==========================================
+ Coverage    94.9%   95.17%   +0.26%     
==========================================
  Files         361      361              
  Lines        6615     6653      +38     
  Branches      277      293      +16     
==========================================
+ Hits         6278     6332      +54     
+ Misses        337      321      -16

Impacted Files	Coverage Δ
laws/src/main/scala/cats/laws/MonadLaws.scala	`100% <0%> (ø)`	⬆️
core/src/main/scala/cats/data/Ior.scala	`98.54% <0%> (+0.01%)`	⬆️
core/src/main/scala/cats/data/Chain.scala	`99.58% <0%> (+0.01%)`	⬆️
core/src/main/scala/cats/Eval.scala	`98.82% <0%> (+0.04%)`	⬆️
core/src/main/scala/cats/data/IorT.scala	`97.79% <0%> (+0.04%)`	⬆️
core/src/main/scala/cats/data/NonEmptyChain.scala	`99.07% <0%> (+0.07%)`	⬆️
...ore/src/main/scala/cats/data/NonEmptyMapImpl.scala	`96.15% <0%> (+0.15%)`	⬆️
.../src/main/scala/cats/data/RepresentableStore.scala	`87.5% <0%> (+4.16%)`	⬆️
core/src/main/scala/cats/syntax/either.scala	`99.26% <0%> (+12.5%)`	⬆️
testkit/src/main/scala/cats/tests/CatsSuite.scala	`70% <0%> (+36.66%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26869d...4b8db50. Read the comment docs.

erikerlandson · 2018-10-31T21:53:44Z

+1, this is on the path for algebra and spire

ChristopherDavenport · 2018-11-01T13:44:05Z

Looks like some sort of scalatest or scalactic bug.

SethTisue · 2018-11-01T15:24:58Z

at a glance, all that spew in the log looks like scalatest/scalatest#1423, but I think the actual failure is something else?

kailuowang · 2018-11-01T18:21:35Z

The previous error was fixed, now I have a randomly occurring error (roughly 50% of the time) on scalajs

[info] - Try with Throwable.monadError.applicativeError recover consistent with recoverWith *** FAILED ***
[info] UndefinedBehaviorError was thrown during property evaluation.
[info] Message: An undefined behavior was detected: scala.runtime.Statics$PFMarker$@26 is not an instance of scala.util.Try
[info] Occurred when passed generated values (
[info] arg0 = Failure(java.lang.Error),
[info] arg1 =
[info] )

erikerlandson · 2018-11-01T20:10:33Z

log spew might be a problem unto itself here?
The job exceeded the maximum log length, and has been terminated.

kailuowang · 2018-11-04T15:51:36Z

Minimized scalajs error example here
I am going to mark this as blocked by scala-js/scala-js#3480 and scalatest/scalatest#1423

kailuowang · 2018-11-04T17:52:27Z

turns out to be a scala.util.Failure regression, reported by @sjrd scala/bug#11242

SethTisue · 2018-11-04T18:36:27Z

can it be worked around for now?

kailuowang · 2018-11-05T00:41:44Z

@SethTisue the scala.util.Failure regression can probably be circumvented by disabling the test on 2.13 temporarily. I am not sure about the scalatest output one. I'll poke around scalatest settings.

…egression

erikerlandson · 2018-11-06T17:45:05Z

just one test failing for (2.13, js_build false) in OpSuite

[info] OpSuite:
[info] - Op[Function1, Char, Int].eq.antisymmetry
[info] - Op[Function1, Char, Int].eq.reflexitivity
[info] - Op[Function1, Char, Int].eq.symmetry
[info] - Op[Function1, Char, Int].eq.transitivity
[info] - Eq[Op[Function1, Char, Int]].serializable.can serialize and deserialize *** FAILED ***
[info]   ClassCastException was thrown during property evaluation.
[info]     Message: cannot assign instance of java.lang.invoke.SerializedLambda to field org.scalacheck.Gen$$anon$5.f$5 of type scala.Function2 in instance of org.scalacheck.Gen$$anon$5
[info]     Occurred when passed generated values (
[info]   
[info]     )
[info] - Op[Function1, Char, Int].category.category left identity
[info] - Op[Function1, Char, Int].category.category right identity
[info] - Op[Function1, Char, Int].category.compose associativity
[info] - Category[Op[Function1, ?, ?]].serializable.can serialize and deserialize

SethTisue · 2018-11-06T17:49:40Z

looks like typelevel/scalacheck#427 (comment) / scala/scala-dev#562

kailuowang · 2018-11-06T17:53:59Z

the fix to this one is to turn fork in test back to true, it was turned to false as a workaround for the scalatest issue. So, if you allow me,
(╯°□°）╯︵ ┻━┻

erikerlandson · 2018-11-06T17:57:53Z

can you just disable this single test using BuildInfo.scalaVersion != "2.13.0-M5" like you did with the other test in TrySuite?

kailuowang · 2018-11-07T14:34:56Z

I'd like to turn fork in test back to true, since that's better memory wise. Cheeseng is looking at scalatest/scalatest#1423 so I am hopeful.

SethTisue · 2018-11-07T15:00:28Z

I'd like to turn fork in test back to true, since that's better memory wise

I'm mostly just curious, but how come it isn't better to just crank up -Xmx some more? I don't recall seeing other projects setting fork to true for this reason (unless they were doing weird things with threads and classloaders, something like that, which I wouldn't expect in this repo)

kailuowang · 2018-11-07T15:15:54Z

@SethTisue good question! Due to the need to generate coverage report, we need to run test from root module and congregate coverage reports (although that may be hackable). Since each test run classloader is not garbage collected, it's probably better memory wise that each module's test is run in a fresh forked jvm.

erikerlandson · 2018-11-08T13:51:22Z

🎉

ceedubs

Nice. Thank you, @kailuowang and everyone else who helped make this happen!

ceedubs · 2018-11-08T14:33:37Z

tests/src/test/scala/cats/tests/TrySuite.scala

@@ -17,7 +17,11 @@ class TrySuite extends CatsSuite {
  checkAll("Try[Int]", CoflatMapTests[Try].coflatMap[Int, Int, Int])
  checkAll("CoflatMap[Try]", SerializableTests.serializable(CoflatMap[Try]))

-  checkAll("Try with Throwable", MonadErrorTests[Try, Throwable].monadError[Int, Int, Int])
+  //temporarily disable this test due to scala.util.Failure regression https://github.com/scala/bug/issues/11242
+  if (BuildInfo.scalaVersion != "2.13.0-M5") {


We might want to open an issue in this repo to remind ourselves to remove this hack.

done: #2601

thanks @erikerlandson

kailuowang added 2 commits October 31, 2018 11:43

updated to 2.13-M5

6795752

reformat

d7d62a3

kailuowang added this to the 1.5 milestone Oct 31, 2018

kailuowang added 3 commits October 31, 2018 12:05

update machinist as well

be91dd3

update sbt

834f9e8

updated kind projector

105ba8e

erikerlandson mentioned this pull request Oct 31, 2018

publish for Scala 2.13.0-M5 typelevel/algebra#219

Closed

SethTisue mentioned this pull request Nov 1, 2018

Prepare for 2.13.0-M5 #2389

Closed

kailuowang added 3 commits November 1, 2018 12:04

fixing the test in 2.13

dc90572

fix fmt

f7b578b

fix mistake made by fmt

64184c4

kailuowang mentioned this pull request Nov 2, 2018

runtime error on 0.6.25 Scala 2.13-M5 scala-js/scala-js#3480

Closed

kailuowang added the Blocked label Nov 4, 2018

kailuowang added 3 commits November 5, 2018 12:02

disbale fork in test on 2.13 due to scalatest issue

01a56bc

temporary disable MonadError test for Try on 2.13 due to scala.util.r…

b8f685b

…egression

fmt

d51d3fb

kailuowang mentioned this pull request Nov 5, 2018

try upgrade scala 2.12.7 #2598

Closed

revert uneccessary change

c990d79

trying scalatest fix

4b8db50

kailuowang removed the Blocked label Nov 8, 2018

LukaJCB approved these changes Nov 8, 2018

View reviewed changes

ceedubs approved these changes Nov 8, 2018

View reviewed changes

erikerlandson mentioned this pull request Nov 8, 2018

Re-enable unit test that was disabled in pr #2589 #2601

Closed

ChristopherDavenport approved these changes Nov 8, 2018

View reviewed changes

kailuowang merged commit 00f2a5f into typelevel:master Nov 8, 2018

kailuowang added the build label Nov 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated to 2.13-M5 #2589

updated to 2.13-M5 #2589

kailuowang commented Oct 31, 2018

codecov-io commented Oct 31, 2018 •

edited

Loading

erikerlandson commented Oct 31, 2018

ChristopherDavenport commented Nov 1, 2018

SethTisue commented Nov 1, 2018 •

edited

Loading

kailuowang commented Nov 1, 2018

erikerlandson commented Nov 1, 2018

kailuowang commented Nov 4, 2018

kailuowang commented Nov 4, 2018

SethTisue commented Nov 4, 2018

kailuowang commented Nov 5, 2018

erikerlandson commented Nov 6, 2018

SethTisue commented Nov 6, 2018

kailuowang commented Nov 6, 2018

erikerlandson commented Nov 6, 2018

kailuowang commented Nov 7, 2018

SethTisue commented Nov 7, 2018

kailuowang commented Nov 7, 2018

erikerlandson commented Nov 8, 2018

ceedubs left a comment

ceedubs Nov 8, 2018

erikerlandson Nov 8, 2018

kailuowang Nov 8, 2018

updated to 2.13-M5 #2589

updated to 2.13-M5 #2589

Conversation

kailuowang commented Oct 31, 2018

codecov-io commented Oct 31, 2018 • edited Loading

Codecov Report

erikerlandson commented Oct 31, 2018

ChristopherDavenport commented Nov 1, 2018

SethTisue commented Nov 1, 2018 • edited Loading

kailuowang commented Nov 1, 2018

erikerlandson commented Nov 1, 2018

kailuowang commented Nov 4, 2018

kailuowang commented Nov 4, 2018

SethTisue commented Nov 4, 2018

kailuowang commented Nov 5, 2018

erikerlandson commented Nov 6, 2018

SethTisue commented Nov 6, 2018

kailuowang commented Nov 6, 2018

erikerlandson commented Nov 6, 2018

kailuowang commented Nov 7, 2018

SethTisue commented Nov 7, 2018

kailuowang commented Nov 7, 2018

erikerlandson commented Nov 8, 2018

ceedubs left a comment

Choose a reason for hiding this comment

ceedubs Nov 8, 2018

Choose a reason for hiding this comment

erikerlandson Nov 8, 2018

Choose a reason for hiding this comment

kailuowang Nov 8, 2018

Choose a reason for hiding this comment

codecov-io commented Oct 31, 2018 •

edited

Loading

SethTisue commented Nov 1, 2018 •

edited

Loading