Post release to Discord in CI #3855
Conversation
| data="{\"content\":\"https://github.com/typelevel/cats-effect/releases/tag/v$1\"}" | ||
| data="{\"content\":\"https://github.com/typelevel/cats-effect/releases/tag/$1\"}" |
There was a problem hiding this comment.
Seems easier to just pass the tag.
There was a problem hiding this comment.
Well, the reason I didn't do it that way is because all the other scripts take a version number unprefixed by v, and it's going to get very confusing if we make it inconsistent.
|
Presumably we eventually want to run the other scripts in CI too? We're just going to butt heads with this again. It's easier to pass a tag in GHA than it is to do string manipulation. Meanwhile, the scripts themselves can easily strip the |
That's fair. Can we change the other scripts then at the same time? This is exactly the sort of stuff that gets really confusing if we aren't strict about it. |
| old_version="${1#v}" | ||
| new_version="${2#v}" |
Follow-up to #3711 that uses the configured secret.