Remove unused code #3729
Merged
Remove unused code #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh, actually whenever you change the base branch, you have to re-trigger CI. the current ✅ is based on CI running against 3.x, not 3.5.x |
|
Huh, great. Cirrus didn't seem to restart with the close/open, so I tried to restart it manually. I don't know if I succeeded... |
|
Ah, actually Cirrus doesn't need to be restarted anyway ... So the difference is that GHA CI runs on a synthetic merge commit. So for example, the initial CI run was on 4ef1966 which merged in Meanwhile, Cirrus runs CI on the branch itself, not a synthetic merge commit. So in both cases it is running on 907b121, it doesn't matter which branch the PR is targeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's private, and nothing uses it.