Add BoolRng and GenBool. Resolves #107. #109
Conversation
| laws[LogicLaws, Set[Byte]].check(_.generalizedBool) | ||
| laws[RingLaws, Set[Byte]].check(_.boolRng(setBoolRng[Byte])) | ||
| laws[LogicLaws, Set[Byte]]("bool-from-rng").check(_.generalizedBool(setBoolRng.asBool)) | ||
| laws[RingLaws, Set[Byte]]("rng-from-bool").check(_.boolRng(GenBool[Set[Byte]].asBoolRing)) |
There was a problem hiding this comment.
Switched from Set[Int] to Set[Byte] in order to have more exhaustive coverage of the domain.
|
Although I used the name |
|
I'm fine with either of those names. I like @johnynek's idea of just merging this as-is ( |
|
If you are fine with it, then go ahead and merge. How do people feel about |
|
👍 |
Add BoolRng and GenBool. Resolves #107.
|
So the idea is that we'd write the relative complement of a in b as |
|
Yes, exactly, so that the argument order of the spelled out name is consistent with the symbolic notation. |
|
Sounds good to me. |
|
I think without is fine. |
This is a work in progress on topless Bool/BoolRing (#107), subject to some renaming. In this version I used the names
GenBoolfor generalized Boolean algebra andwithout(a, b)fora\b(relative complement of b with respect to a).