Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

represent choices in ChoiceField as Sequence #686

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

asottile
Copy link
Contributor

this enforces that choices are in a deterministic order for forms / schemas / etc.

I have made things!

Related issues

resolves #454

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
this enforces that choices are in a deterministic order for forms / schemas / etc.
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevn sobolevn merged commit 0dc8b42 into typeddjango:master Oct 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

consider Sequence[Any] instead of Iterable[Any] for ChoiceFields choices
2 participants