Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions release workflow #660

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Sep 11, 2024

Heavily based on the setup in django-stubs:

Benefits:

Heavily based on the setup in `django-stubs`
@intgr intgr added the github_actions Pull requests that update GitHub Actions code label Sep 11, 2024
@intgr intgr changed the title Set up release automation Add GitHub actions release workflow Sep 11, 2024
@intgr intgr marked this pull request as ready for review September 11, 2024 21:16
@intgr
Copy link
Contributor Author

intgr commented Sep 11, 2024

@sobolevn needs to configure a PyPI trusted publisher, I'm guessing this should be:

Owner: typeddjango
Repository name: djangorestframework-stubs
Workflow name: release.yml
Environment name: release

(Related discussion in django-stubs: typeddjango/django-stubs#2114)

@intgr
Copy link
Contributor Author

intgr commented Sep 11, 2024

Pinging @flaeppe as the author of original django-stubs release workflow.

@sobolevn
Copy link
Member

Working on it!

@sobolevn
Copy link
Member

Done!
Снимок экрана 2024-09-13 в 11 09 38

@sobolevn sobolevn merged commit e83591d into typeddjango:master Sep 13, 2024
13 checks passed
@intgr
Copy link
Contributor Author

intgr commented Sep 13, 2024

Now all we need is an excuse to make another release to test it 😁

@intgr intgr deleted the release-automation branch September 13, 2024 19:42
@browniebroke
Copy link
Contributor

I saw that there was a new django-stubs release today... Would now be a good time to make a new release for drf-stubs too? 😄

@intgr
Copy link
Contributor Author

intgr commented Dec 14, 2024

It worked! 🥳 https://github.com/typeddjango/djangorestframework-stubs/actions/runs/12329324930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Development

Successfully merging this pull request may close these issues.

4 participants