Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix APIRequestFactory method signatures #634

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Fix APIRequestFactory method signatures #634

merged 1 commit into from
Jul 3, 2024

Conversation

DongwookKim0823
Copy link
Contributor

I have made things!

I have updated the method signatures in APIRequestFactory to include the correct types and removed unnecessary variables.

  • Removed the follow: bool = ... parameter from all methods.
  • Updated the options method to accept data: dict[str, str] | str | None.

intgr
intgr approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@intgr intgr changed the title Fix types in APIRequestFactory method signatures Fix APIRequestFactory method signatures Jul 3, 2024
@intgr intgr merged commit 2c27b50 into typeddjango:master Jul 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intgr intgr intgr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DongwookKim0823 @intgr