Mypy: Don't ignore missing imports (remove ignore_missing_imports)
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intgr
commented
May 10, 2024
intgr
commented
May 10, 2024
| except ImportError: | ||
| coreschema: TypeAlias = None # type: ignore[no-redef] | ||
| try: | ||
| import yaml | ||
| except ImportError: | ||
| yaml: TypeAlias = None # type: ignore[no-redef] | ||
| try: | ||
| import inflection | ||
| import inflection # type: ignore[import-not-found,unused-ignore] |
There was a problem hiding this comment.
Since we don't do anything with inflection, only re-export it via rest_framework.compat, it seems unnecessary to add it even as an optional dependency.
sobolevn
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fortunately this was not hiding any genuine bugs in DRF-stubs.
Related issues
ignore_missing_importsoption django-stubs#2058