Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ModelSerializer.build_standard_field(model_field=) parameter typing #541

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

noamkush
Copy link
Contributor

This fixes the annotation for ModelSerializer.build_standard_field which takes the field instance and not the type.

@intgr intgr self-assigned this Mar 19, 2024
@intgr intgr changed the title Fixed build_standard_field parameter typing. Fixed ModelSerializer.build_standard_field(model_field=) parameter typing. Mar 19, 2024
@intgr intgr changed the title Fixed ModelSerializer.build_standard_field(model_field=) parameter typing. Fixed ModelSerializer.build_standard_field(model_field=) parameter typing Mar 19, 2024
Copy link
Contributor

@intgr intgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you are correct.

@intgr intgr merged commit 3b185d3 into typeddjango:master Mar 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants