Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow None for several Field constructor arguments #498

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Allow None for several Field constructor arguments #498

merged 1 commit into from
Oct 23, 2023

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Oct 22, 2023 •
edited
Loading

  • Many args that defaulted to None weren't typed as accepting None.
  • Also relation field source= was typed to accept Callable | str, but callable was never allowed. It may be the name of a method as string.

Related issues

@intgr
Fix Field constructor argument None'ability
ceda9cb 
* Also relation field `source=` was typed to accept `Callable | str`, but callable was never allowed. It may be the *name* of a method as string.
@intgr intgr force-pushed the fix-Field-arg-Noneability branch from 62c21a5 to ceda9cb Compare October 23, 2023 08:44
@intgr intgr changed the title Fix Field constructor argument None'ability Allow None for several Field constructor arguments Oct 23, 2023
@intgr intgr merged commit 3a0197a into typeddjango:master Oct 23, 2023
11 checks passed
@intgr intgr deleted the fix-Field-arg-Noneability branch October 23, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intgr @sobolevn