Fix and enable Ruff lints PYI002, PYI026 #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Oct 23, 2023
These affect `rest_framework-stubs/compat.pyi` which is using some weird hacks that Ruff and mypy don't really like. * PYI002: If test must be a simple comparison against sys.platform or sys.version_info * PYI026: Use typing_extensions.TypeAlias for type aliases
intgr
force-pushed
the
ruff-lints-part1
branch
from
1e693ad to
b86a5f9
Compare
sobolevn
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These affect
rest_framework-stubs/compat.pyiwhich is using some weird hacks that Ruff and mypy don't really like.Related issues
These were deferred from #488.