Harmonize mypy.ini config with django-stubs
#479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Most of the overrides in `tests/plugins.ini` are no longer needed * Removed lots of unneeded `# type: ignore` comments * Will create a separate PR to update `disallow_untyped_defs` and `disallow_incomplete_defs` too
intgr
commented
Oct 4, 2023
| @@ -46,9 +46,9 @@ class OR(_SupportsHasPermission): | |||
| class NOT(_SupportsHasPermission): | |||
| def __init__(self, op1: _SupportsHasPermission) -> None: ... | |||
|
|
|||
| class BasePermissionMetaclass(OperationHolderMixin, type): ... # type: ignore[misc] | |||
| class BasePermissionMetaclass(OperationHolderMixin, type): ... # type: ignore[misc,unused-ignore] | |||
There was a problem hiding this comment.
This gives different mypy errors depending on Python version, hence ignoring unused-ignore
intgr
commented
Oct 4, 2023
Comment on lines
+12
to
+14
| # TODO: enable disallow_*_defs later | ||
| disallow_untyped_defs = false | ||
| disallow_incomplete_defs = false |
There was a problem hiding this comment.
Will be handled in #480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/plugins.iniare no longer needed# type: ignorecommentsdisallow_untyped_defsanddisallow_incomplete_defstooRelated issues