Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate Field.default_error_messages as a ClassVar #464

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Annotate Field.default_error_messages as a ClassVar #464

merged 2 commits into from
Oct 4, 2023

Conversation

brianhelba
Copy link
Contributor

This clarifies that this field is set on the class itself, not on instances.

@brianhelba
Annotate Field.default_error_messages as a ClassVar
be6a34f 
This clarifies that this field is set on the class itself, not on instances.
@brianhelba
Copy link
Contributor Author

@sobolevn The tests on master appear to be broken. I don't think this is a failure with this PR.

@brianhelba
Copy link
Contributor Author

Tests are fixed by #465.

@intgr intgr merged commit 9bce985 into typeddjango:master Oct 4, 2023
8 checks passed
@brianhelba brianhelba deleted the classvar branch October 5, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianhelba @intgr