-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.7 compatibility #399
Conversation
* Latest Django 4.2 no longer supports Python 3.7 * Our CI dependency `pre-commit` no longer supports Python 3.7 * Python 3.7 support ends in 2 months (https://endoflife.date/python)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to run pyupgarde
with new config? Now it says 3.6
: https://github.com/typeddjango/djangorestframework-stubs/blob/master/.pre-commit-config.yaml#L17
For some reason pyupgrade isn't running correctly on this repo (DRF). When I run |
It's probably something really dumb, but I couldn't figure it out. Submitted an issue to pre-commit: pre-commit/pre-commit#2862 |
This reverts commit d7ef35f.
Yep, pre-commit does not run |
Feels a bit harsh, to be honest. But, looks like we don't run 🤔 Relevant discussions (nothing quite interesting): https://github.com/python/typeshed/search?q=pyupgrade&type=issues So, we can just run this manually for now. Until some better solution comes up. |
Pyupgrade checks are implemented in ruff, you can try using it instead. |
OK this should be mergeable now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
pre-commit
no longer supports Python 3.7 (Bump pre-commit from 2.21.0 to 3.2.2 #391)Related issues