Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Use django-stubs 1.14.0 for testing #346

Merged
merged 3 commits into from
Feb 9, 2023
Merged

CI: Use django-stubs 1.14.0 for testing #346

merged 3 commits into from
Feb 9, 2023

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Feb 7, 2023 •
edited
Loading

Needs changes to our typecheck ignores.

Related issues

Closes #328

@intgr intgr marked this pull request as draft February 7, 2023 16:01
@intgr intgr force-pushed the upgrade-django-stubs branch from 7734e2f to 2b3e2b6 Compare February 9, 2023 09:32
@intgr intgr marked this pull request as ready for review February 9, 2023 09:37
@intgr intgr added the help wanted Extra attention is needed label Feb 9, 2023
@intgr intgr mentioned this pull request Feb 9, 2023
Closed
@intgr intgr changed the title Upgrade to django-stubs 1.14.0 CI: Use django-stubs 1.14.0 for testing Feb 9, 2023
mschoettle
mschoettle approved these changes Feb 9, 2023
View reviewed changes
Copy link

@mschoettle mschoettle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

I see there are also removals from the ignores. What is the process to update these when updating the stubs? Do they all have to be verified each time DRF or stubs are updated?

@intgr
Copy link
Contributor Author

intgr commented Feb 9, 2023

I see there are also removals from the ignores. What is the process to update these when updating the stubs?

At the end of typecheck run output there is a "UNUSED IGNORES" block, which is helpful for cleaning up unneeded ignores: https://github.com/typeddjango/djangorestframework-stubs/actions/runs/4132844223/jobs/7142029536#step:6:425

Although it doesn't currently work for __common__ ignores. Also note that unused ignores vary by Python version, so some unused ones are expected.

@intgr
Copy link
Contributor Author

intgr commented Feb 9, 2023

Thanks for the review!

@intgr intgr merged commit fddecec into typeddjango:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mschoettle mschoettle mschoettle approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intgr @mschoettle