Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI: add typecheck suppression & upgrade flake8-pyi #303

Merged
merged 3 commits into from
Dec 3, 2022
Merged

Fix CI: add typecheck suppression & upgrade flake8-pyi #303

merged 3 commits into from
Dec 3, 2022

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Dec 2, 2022 •
edited
Loading

  • Added suppression for a new test in upstream
  • Upgraded flake8-pyi to be compatible with flake8 v6:
    Collecting flake8-pyi==22.10.0
      Downloading flake8_pyi-22.10.0-py37-none-any.whl (24 kB)
    
    The conflict is caused by:
        The user requested flake8 6.0.0 (from /home/runner/.cache/pre-commit/repovn0unijf)
        flake8-pyi 22.10.0 depends on flake8<6.0.0 and >=3.2.1

@intgr intgr changed the title Fix typecheck in CI: add suppression Fix CI: add typecheck suppression & downgrade flake8 Dec 2, 2022
@intgr intgr marked this pull request as ready for review December 2, 2022 16:04
This was referenced Dec 2, 2022
Merged
Merged
@intgr intgr changed the title Fix CI: add typecheck suppression & downgrade flake8 Fix CI: add typecheck suppression & upgrade flake8-pyi Dec 3, 2022
@intgr intgr requested a review from sobolevn December 3, 2022 08:32
sobolevn
sobolevn approved these changes Dec 3, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@intgr intgr merged commit 3cdc675 into typeddjango:master Dec 3, 2022
@intgr intgr mentioned this pull request Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intgr @sobolevn