Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub auto release notes #229

Merged

Conversation

terencehonles
Copy link
Contributor

This change is described in typeddjango/django-stubs#988 and keeps this action in sync w/ that repo.

Related issues

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you please check why it is red right now?

@terencehonles terencehonles force-pushed the enable-github-auto-release-notes branch from c1de0a2 to c110d4e Compare June 13, 2022 16:49
@terencehonles
Copy link
Contributor Author

This change is causing the type checking on the tests to fail since the base class defines a permission of length 1 and mypy assumes it's a list of the same time instead of a list of the base class:

encode/django-rest-framework@e7af8d6#diff-05cdbfa2f026a57bd8fe310dc81f32e4f34ffc2333888790ffd90cada058f71cR26

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it!

@sobolevn sobolevn merged commit fa28832 into typeddjango:master Jun 13, 2022
@terencehonles terencehonles deleted the enable-github-auto-release-notes branch June 13, 2022 18:37
@terencehonles
Copy link
Contributor Author

No prob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants