Make method_name optional in SerializerMethodField #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
approved these changes
Jan 17, 2022
|
I see that CI is red, but I'm not sure if any of that is caused by this branch, or just the main branch already being red. |
|
Looks like the |
https://www.django-rest-framework.org/api-guide/fields/#serializermethodfield You can leave the method_name parameter empty, to get a default value. For a long time, drf even gave an error when you provided a parameter that matched `get_` your field name: encode/django-rest-framework#2420
stianjensen
force-pushed
the
optional-method-name
branch
from
e794812 to
00858e6
Compare
|
Rebased on master now that it looks green again. |
sobolevn
approved these changes
Apr 1, 2022
XF-FW
pushed a commit
to XF-FW/djangorestframework-stubs
that referenced
this pull request
Apr 7, 2022
https://www.django-rest-framework.org/api-guide/fields/#serializermethodfield You can leave the method_name parameter empty, to get a default value. For a long time, drf even gave an error when you provided a parameter that matched `get_` your field name: encode/django-rest-framework#2420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.django-rest-framework.org/api-guide/fields/#serializermethodfield
You can leave the method_name parameter empty, to get a default value.
For a long time, drf even gave an error when you provided a parameter that matched
get_your field name:encode/django-rest-framework#2420