Fix type of min_value and max_value on DecimalField #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should at the very least allow Decimals. Technically you can send in anything that's comparable to a Decimal, but I'm not sure if it makes sense to allow floats. Could allow both ints and Decimals I guess?
sobolevn
reviewed
May 9, 2022
django-stubs/forms/fields.pyi
Outdated
| @@ -125,8 +125,8 @@ class DecimalField(IntegerField): | |||
| def __init__( | |||
| self, | |||
| *, | |||
| max_value: Optional[int] = ..., | |||
| min_value: Optional[int] = ..., | |||
| max_value: Optional[Decimal] = ..., | |||
There was a problem hiding this comment.
>>> from decimal import Decimal
>>> Decimal(1.5) > 1.2
True
>>> Decimal(1.5) > 1
TrueLet's include int and float
There was a problem hiding this comment.
Alright, I've included them now. Kinda disagree about floats though, because the imprecise nature of floats. If you've decided to use a decimal field I assume you want accuracy, even though a float technically works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should at the very least allow Decimals. Technically you can send in anything that's comparable to a Decimal, but I'm not sure if it makes sense to allow floats. Could allow both ints and Decimals I guess?
In the Django codebase these arguments are sent to
MinValueValidatorandMaxValueValidatorwhich just doesa < b/a > b.