Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return type of queryset.bulk_update to int #683

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

abhiabhi94
Copy link
Contributor

I'm not sure if this can be merged as of now, since this applies only to the main branch of django as of now, and will be released in 4.0.

@abhiabhi94 abhiabhi94 force-pushed the feat/change-bulk-update branch from a833440 to 4ae2de8 Compare July 30, 2021 18:37
@sobolevn
Copy link
Member

I'm not sure if this can be merged as of now

Yes, let's keep it None for now. We only support django@3 for now.

@flaeppe
Copy link
Member

flaeppe commented Jan 3, 2022

Is it possible to merge this now? Can't see that it was part of #786

@sobolevn
Copy link
Member

sobolevn commented Jan 4, 2022

@flaeppe sure! Can you please rebase it?

@abhiabhi94
Copy link
Contributor Author

if it's okay, i will rebase it in some time.

@abhiabhi94 abhiabhi94 force-pushed the feat/change-bulk-update branch from 4ae2de8 to 11f898e Compare January 4, 2022 16:34
@abhiabhi94 abhiabhi94 force-pushed the feat/change-bulk-update branch from 11f898e to d1c9504 Compare January 5, 2022 15:13
@abhiabhi94
Copy link
Contributor Author

updated.

For what it is worth, django 4.0 has dropped support for python 3.6 and 3.7, maybe we don't need to test against those versions in the CI?

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants