Make as_manager method use proper generic #327
Conversation
silviogutierrez
commented
Feb 13, 2020
silviogutierrez
commented
- Closes Make as_manager() in queryset generic instead of using Any #324
| @@ -41,7 +41,7 @@ class _BaseQuerySet(Generic[_T], Sized): | |||
| hints: Optional[Dict[str, models.Model]] = ..., | |||
| ) -> None: ... | |||
| @classmethod | |||
| def as_manager(cls) -> Manager[Any]: ... | |||
| def as_manager(cls) -> Manager[_T]: ... | |||
There was a problem hiding this comment.
Can you please also test it? We have a lot of bugs in QuerySet / Manager topics.
And we want to be sure it is as stable as possible.
|
Possible duplicate work in #290. |
|
@sobolevn : forgive me if I missed it, but is there a guide to running or developing locally? I'm trying to run tests and doing it through CI passes really takes a while. Got a lot of other fixes too that I'd love to contribute back. I tried replicating the Travis steps but no luck. An example here: https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/unit-tests/#running-the-unit-tests |
|
Yes, we have a really short guide: https://github.com/typeddjango/django-stubs/blob/master/CONTRIBUTING.md It is not perfect and I am open for any feedback! |
|
Has this been abandoned? |
|
We are waiting for this change as well as it is blocking us upgrading to Python 3.9. Is this still only waiting on tests @sobolevn? |
|
It does look like the PR includes a test already - I'm happy to help if there's anything needed to move this forward. |
|
I would love to merge this after the CI is fixed. |
|
After investigating a bit more - looks like this simple approach doesn't quite work and it will probably need some of the more advanced machinery from #272 or #290. I'd recommend closing this PR in favor of one of the other two unless @silviogutierrez has some further input on it. |
